Skip to content

[PB-5493]: feature/show the downloaded bytes when downloading items #1833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xabg2 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[PB-5493]: feature/show the downloaded bytes when downloading items #1833

xabg2 wants to merge 5 commits into from
+446 −117

Conversation

@xabg2
Copy link
Contributor

@xabg2 xabg2 commented Jan 29, 2026 •
edited
Loading

Display the downloaded bytes progress when downloading folders/items.

Description

Related Issues

Related Pull Requests

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

Testing Process

Additional Notes

@xabg2
feature: show the downloaded bytes when downloading items
b07fb5a 
fix: typo

feat: track downloaded bytes from a folder

fix: update function name

fix: remove nItems and use the downloadedProgress instead
@xabg2 xabg2 self-assigned this Jan 29, 2026
@xabg2 xabg2 added the enhancement New feature or request label Jan 29, 2026
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 29, 2026 •
edited
Loading

Deploying drive-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8023a27
Status: ✅  Deploy successful!
Preview URL: https://851e7b56.drive-web.pages.dev
Branch Preview URL: https://fix-show-correct-info-when-d.drive-web.pages.dev

View logs

@xabg2 xabg2 marked this pull request as ready for review January 30, 2026 11:20
@xabg2 xabg2 requested review from a team, CandelR and larryrider as code owners January 30, 2026 11:20
sg-gs
sg-gs reviewed Jan 30, 2026
View reviewed changes
Copy link
Member

@sg-gs sg-gs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this keep the items count progress also? We added that because for cases with a lot of small files, the download bytes was not the most realistic way of reporting the download progress

@xabg2
Copy link
Contributor Author

xabg2 commented Jan 30, 2026

Does this keep the items count progress also? We added that because for cases with a lot of small files, the download bytes was not the most realistic way of reporting the download progress

No, it doesn't. Because the count + download progress don't fit in the task log. Also, Paula and I discussed it yesterday and agreed that it's better to show the user that something is happening rather than the items, because if there is a heavy item, the count doesn't add up, but the download progress does.

@xabg2 xabg2 requested a review from sg-gs January 30, 2026 12:03
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 8, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larryrider larryrider larryrider approved these changes

@sg-gs sg-gs sg-gs approved these changes

@CandelR CandelR Awaiting requested review from CandelR CandelR is a code owner

Assignees

@xabg2 xabg2

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xabg2 @larryrider @sg-gs